Re: MSVC and fseeko.c

[Bruno Haible]

Gisle Vanem wrote:
> Bruno Haible wrote:
> 
> > $ ./gnulib-tool --create-testdir --dir=/tmp/testdir-stdioext --with-tests \
> >                 --single-configure --avoid=havelib-tests \
> >                 fseterr freadable fwritable fbufmode freading fwriting \
> >                 freadptr freadseek freadahead fpurge fseeko ftello fpending 
> > \
> >                 fflush
> > 
> > With this patch, this testdir passes its testsuite on MSVC 14, both in 
> > 32-bit
> > and in 64-bit mode, except for the 'fpending' module.
> 
> Thanks alot for your effort on this. It compiles fine, but I'm not sure
> it works for all test-f*.exe tests. In test-fseeko.exe, I get this assert:
>   test-fseeko.c:45: assertion 'r1 == r2 && r1 == expected' failed
> 
> (r1 = -1, r2 = 0, expected = 0).

And what about the other tests? When "make check" runs, which fail?
(This info should give a hint about where to start looking.)

> You tested this with MSVC 14?

Yes.

> Does this use the "old" MSVCRT.dll?

No, it uses vcruntime140.dll.

> BTW. I'm on Win-10 using MSVC 2015 and the WindowsKit (Universal CRT
> ver. 10.0.10586.0).

Mine is 10.0.10240.0.

> I noticed you patched stdio-impl.h with the 'struct _gl_real_FILE' stuff.
> Are you sure this is compatible with this newer Windows SDK?

No, Microsoft won't tell me when they make internal changes in their library.

Bruno