[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: coreutils snapshot vs gcc7-to-be: new test-calloc-gnu.c and test-can
From: |
Jim Meyering |
Subject: |
Re: coreutils snapshot vs gcc7-to-be: new test-calloc-gnu.c and test-canonicalize.c warnings |
Date: |
Sat, 4 Mar 2017 17:37:23 -0800 |
On Sat, Mar 4, 2017 at 5:21 PM, Bruno Haible <address@hidden> wrote:
> Hi Jim,
>
> Jim Meyering wrote:
>> I've just fixed that with the attached and just-pushed gnulib patch:
>
> You "fixed" it by disabling a valuable test! I propose to restore the test
> and instead only disable GCC's ability to produce a warning. Like this:
>
>
> 2017-03-04 Bruno Haible <address@hidden>
>
> test-calloc-gnu: Reenable test also for GCC 7.
> * tests/test-calloc-gnu.c (eight): New function.
> (main): Don't skip test; use eight() instead.
Hi Bruno,
Thanks for your vigilance. I do indeed prefer your change.