bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] manywarnings: update for GCC 7


From: Bruno Haible
Subject: Re: [PATCH] manywarnings: update for GCC 7
Date: Tue, 16 May 2017 19:41:03 +0200
User-agent: KMail/5.1.3 (Linux/4.4.0-75-generic; KDE/5.18.0; x86_64; ; )

Hi Paul,

> +#ifndef FALLTHROUGH
> +# if __GNUC__ < 7
> +#  define FALLTHROUGH ((void) 0)

Why not
   #  define FALLTHROUGH
? Would that generate warnings about empty statements?

> diff --git a/tests/test-sigpipe.c b/tests/test-sigpipe.c
> index 48b22f1..e75372d 100644
> --- a/tests/test-sigpipe.c
> +++ b/tests/test-sigpipe.c
> @@ -26,6 +26,8 @@ int s = SIGPIPE;
>  #include <stdlib.h>
>  #include <unistd.h>
>  
> +#include "macros.h"
> +
>  static void
>  handler (int sig)
>  {

This needs an update of the module description:


diff --git a/ChangeLog b/ChangeLog
index ec82d08..9eedc53 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2017-05-16  Bruno Haible  <address@hidden>
+
+       sigpipe tests: Fix file list.
+       * modules/sigpipe-tests (Files): Add tests/macros.h.
+
 2017-05-16  Paul Eggert  <address@hidden>
 
        manywarnings: update for GCC 7
@@ -9,6 +14,8 @@
        * lib/strftime.c, lib/dfa.c, lib/fnmatch.c, lib/mbrtowc.c:
        * lib/vasnprintf.c, tests/macros.h (FALLTHROUGH): New macro.
        Use it whenever one switch case falls through into the next.
+       * lib/fnmatch_loop.c, tests/test-mbrtowc.c, tests/test-sigpipe.c:
+       Use FALLTHROUGH macro.
 
 2017-05-15  Bruno Haible  <address@hidden>
 
diff --git a/modules/sigpipe-tests b/modules/sigpipe-tests
index 99107a6..df01640 100644
--- a/modules/sigpipe-tests
+++ b/modules/sigpipe-tests
@@ -1,6 +1,7 @@
 Files:
 tests/test-sigpipe.c
 tests/test-sigpipe.sh
+tests/macros.h
 
 Depends-on:
 write




reply via email to

[Prev in Thread] Current Thread [Next in Thread]