Re: [PATCH] fallthrough: update for GCC 7/8

[Bernhard Voelker]

On 05/20/2017 02:12 AM, Jim Meyering wrote:
> * lib/quotearg.c (FALLTHROUGH): New macro.
> Use it whenever one switch case falls through into the next,
> replacing "/* Fall through */" comments.  This exposed one
> instance of an unwarranted "fall through" comment: unwarranted
> because it preceded a "goto" label not a case statement.

Here's a diff output with one more line of context:

@@ -504,9 +512,8 @@ quotearg_buffer_restyled (char *buffer, size_t buffersize,
         c_and_shell_escape:
           if (quoting_style == shell_always_quoting_style
               && elide_outer_quotes)
             goto force_outer_quoting_style;
-          /* Fall through.  */
         c_escape:
           if (backslash_escapes)
             {
               c = esc;

IMO the "fall through" comment was warranted ... in the else case.

Have a nice day,
Berny