bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] quotearg: fix compilation failure due to FALLTHROUGH misuse


From: Jim Meyering
Subject: [PATCH] quotearg: fix compilation failure due to FALLTHROUGH misuse
Date: Thu, 25 May 2017 21:27:51 -0700

FYI, I've just pushed this:

>From 6c720446ab4f450b86fe61113096d09f64029de4 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Thu, 25 May 2017 21:25:37 -0700
Subject: [PATCH] quotearg: fix compilation failure due to FALLTHROUGH misuse

* lib/quotearg.c (quotearg_buffer_restyled): Revert one FALLTHROUGH
macro back to /* fall through */ comment.  The macro can apply only
to a following case statement.  Reported by Assaf Gordon.
---
 ChangeLog      | 7 +++++++
 lib/quotearg.c | 2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index 3e78d5a..2252a4a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2017-05-25  Jim Meyering  <address@hidden>
+
+       quotearg: fix compilation failure due to FALLTHROUGH misuse
+       * lib/quotearg.c (quotearg_buffer_restyled): Revert one FALLTHROUGH
+       macro back to /* fall through */ comment.  The macro can apply only
+       to a following case statement.  Reported by Assaf Gordon.
+
 2017-05-25  Paul Eggert  <address@hidden>

        intprops: port to recent icc
diff --git a/lib/quotearg.c b/lib/quotearg.c
index f1bdf31..06172c1 100644
--- a/lib/quotearg.c
+++ b/lib/quotearg.c
@@ -513,7 +513,7 @@ quotearg_buffer_restyled (char *buffer, size_t buffersize,
           if (quoting_style == shell_always_quoting_style
               && elide_outer_quotes)
             goto force_outer_quoting_style;
-          FALLTHROUGH;
+          /* fall through */
         c_escape:
           if (backslash_escapes)
             {
-- 
2.9.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]