bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] quotearg: fix compilation failure due to FALLTHROUGH misuse


From: Bernhard Voelker
Subject: Re: [PATCH] quotearg: fix compilation failure due to FALLTHROUGH misuse
Date: Mon, 29 May 2017 23:30:29 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0

On 05/29/2017 04:51 AM, Jim Meyering wrote:
> On Sun, May 28, 2017 at 3:44 AM, Bernhard Voelker
> <address@hidden> wrote:
>>>              goto force_outer_quoting_style;
>>> -          FALLTHROUGH;
>>> +          /* fall through */
>>>          c_escape:
>>>            if (backslash_escapes)
>>>              {
>>
>> Sorry, you lost me:
>> "c_escape:" /is/ a case statement, so what's the matter here?
> 

> That "c_escape:" is a goto label (not a case label), so putting the
> attribute before it would evoke a compilation error from newer gcc.

ah, right.  So your initial patch to remove the fall through
marker was correct as we don't need them for goto labels ...
like e.g. 5 lines above.

Sorry for the confusion.  I'll get my glasses in a couple of days.

Thanks & have a nice day,
Berny




reply via email to

[Prev in Thread] Current Thread [Next in Thread]