[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Memleak in glob()
|
From: |
Bruno Haible |
|
Subject: |
Re: Memleak in glob() |
|
Date: |
Sun, 02 Jul 2017 02:34:17 +0200 |
|
User-agent: |
KMail/5.1.3 (Linux/4.4.0-81-generic; KDE/5.18.0; x86_64; ; ) |
Hi Tim,
> Attached is a patch fixing the issue for me
The 'return 0;' in line 1104 is correct, because 'dirname' is stuffed into
the result array in the lines before. Therefore dirname must NOT be freed
here.
For the other ones, you may be right, but I wonder why scan.coverity.com did
not display them? Probably we need to upload a new build to scan.coverity.com.
Which brings me to a status question: Did you find volunteers for the triage
of the "defects" on scan.coverity.com? I stopped looking into it when you
said you would find some people.
Ultimately, for functions as complex as glob(), I now trust coverity.com
more than any person's review (including mine myself). Therefore I would like
to pursue the approach of using scan.coverity.com.
Bruno
Re: Memleak in glob(), Paul Eggert, 2017/07/02