Re: stdioext OpenVMS patch.

[John E. Malmberg]

On 7/1/2017 7:47 PM, Bruno Haible wrote:
> Hi John,
>
> > On OpenVMS, the struct _iobuf is needed to access members of the struct
> > FILE.
> >
> > This is a patch for the affected stdioext modules to compile on OpenVMS.
>
> The approach looks generally right, but I'd request a couple of changes
> before this can go in:
>    * Instead of defining a variable 'stream', please using the same
>      coding style as for the other platforms: use macro fp_ which
>      is defined to a cast expression through lib/stdio-impl.h.

Thank you.  That greatly simplifies the updated attached patch.

>    * Is _IOERR defined on OpenVMS? In some files, you treat OpenVMS
>      as part of the _IOERR case, in others you do it before _IOERR. Which
>      is not consistent.
>      If _IOERR is defined on OpenVMS, please update all
>        #elif defined _IOERR                /* AIX, HP-UX, IRIX, OSF/1, Solaris, 
> OpenServer,
> mingw, MSVC, NonStop Kernel */
>      lines to include OpenVMS at the end of the comment.

Done

>    * The fbufmode.c change has a regression for all non-Windows, non-OpenVMS
>      platforms.

Reverted back to original code.

>    * The freading.c change is misindented.

No longer applicable.

Regards,
-John

0001-stdio.ext-Port-to-OpenVMS_2.patch.gz
Description: GNU Zip compressed data