bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/6] fts: cache dirent_inode_sort_may_be_useful too


From: Tom G. Christensen
Subject: Re: [PATCH 4/6] fts: cache dirent_inode_sort_may_be_useful too
Date: Wed, 9 Aug 2017 12:22:07 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0

On 25/07/17 09:28, Paul Eggert wrote:
* lib/fts.c (struct dev_type): New struct.
(DEV_TYPE_HT_INITIAL_SIZE): New constant.
(dev_type_hash, dev_type_compare, filesystem_type): New functions.
(dirent_inode_sort_may_be_useful, leaf_optimization_applies):
Now takes FTSENT const *, not int.  All uses changed.  Use
filesystem_type to cache.
(link_count_optimize_ok): Remove.  Caller changed to use
leaf_optimization_applies, which now uses shared cache.

This broke the build on CentOS 6 since it has glibc 2.12 which is from before the introduction of the internal __fsword_t type.

gcc -std=gnu99 -DHAVE_CONFIG_H -DEXEEXT=\"\" -DEXEEXT=\"\" -DNO_XMALLOC -DEXEEXT=\"\" -I. -I.. -DGNULIB_STRICT_CHECKING=1 -fvisibility=hidden -g -O2 -Wall -MT fts.o -MD -MP -MF $depbase.Tpo -c -o fts.o fts.c &&\
        mv -f $depbase.Tpo $depbase.Po
fts.c:706: error: expected specifier-qualifier-list before '__fsword_t'
fts.c:734: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'filesystem_type'
fts.c: In function 'dirent_inode_sort_may_be_useful':
fts.c:795: warning: implicit declaration of function 'filesystem_type'
make[4]: *** [fts.o] Error 1

-tgc



reply via email to

[Prev in Thread] Current Thread [Next in Thread]