bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: clang's Undefined Sanitizer


From: Paul Eggert
Subject: Re: clang's Undefined Sanitizer
Date: Wed, 23 Aug 2017 14:48:51 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

On 08/22/2017 02:55 PM, Adhemerval Zanella wrote:
The patchset I sent today only have patches to sync with gnulib
implementation, cleanup some non required support for glibc, and
consolidate glibc various implementation to simplify the code.
It is not meant to fix any current bugs or issues (aside the ones
from gnulib sync), but rather to refactor the code.

OK, thanks. With that in mind I attempted to merge that patchset into Gnulib by installing the attached. In the process I found and fixed a few minor problems with the patchset. I'll follow up on libc-alpha, by proposing a patch there that merges the latest Gnulib into your patchset.


The one I am referring is in my previous interaction that I
want to re-send in following day (maybe after this set being
pushed upstream) and it basically rewrites how the 'struct
globnames' are defined and accessed [1] to use glibc 'dynarray'
internal data structure. That's why I said flexmember is not
really required.

[1]https://sourceware.org/ml/libc-alpha/2017-08/msg00453.html

OK, I plan to look at this later.

It's good to get glibc and Gnulib merged first (as I'm attempting to help do with the attached) before redoing glob.c storage allocation. Since the flexible-member stuff is needed to keep Gnulib glob.c working on some platforms, the attached patch keeps that stuff in. We can remove it later when we make the dynarray changes to Gnulib, assuming dynarray doesn't need it.

Attachment: 0001-glob-merge-from-glibc-with-Zanella-glob-changes.patch
Description: Text Data

Attachment: 0002-flexmember-fix-typo-in-previous-patch.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]