[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] scratch_buffer: new module

From: Florian Weimer
Subject: Re: [PATCH 2/3] scratch_buffer: new module
Date: Sat, 2 Sep 2017 09:31:44 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

On 09/02/2017 01:33 AM, Paul Eggert wrote:

> +AC_CHECK_FUNCS_ONCE([__libc_scratch_buffer_grow])

This configure test is invalid because __libc_scratch_buffer_grow is a
GLIBC_PRIVATE symbol not part of the ABI.

You really need to rename those __libc_* functions because they are in
the internal glibc namespace.

Furthermore, struct scratch_buffer depends on a GNU C extension:
assignment to an object changes its dynamic type.  It is not standard C.
 Standard C only allows one way to allocate untyped memory, and that is


reply via email to

[Prev in Thread] Current Thread [Next in Thread]