[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] Use C11 _Alignas on scratch_buffer internal buffer

From: Adhemerval Zanella
Subject: Re: [PATCH 2/2] Use C11 _Alignas on scratch_buffer internal buffer
Date: Fri, 22 Sep 2017 09:10:37 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

On 21/09/2017 19:53, Paul Eggert wrote:
> Adhemerval Zanella wrote:
>> Now back to the patch topic, I think the first union version [1] should
>> the most suitable one and it is what I am intended to push.
>> [1]https://sourceware.org/ml/libc-alpha/2017-09/msg00730.html
> The code for that looks fine for Gnulib. However, the commit message could be 
> improved. It needs a summary line that does not mention _Alignas. "an union" 
> should be "a union". There is no need to cite every use affected by the 
> change; just say "All uses changed". It would be nice to credit Florian for 
> pointing out the problem and Andreas for suggesting a solution.
> Attached is a proposed patch to Gnulib, which uses the same code as the 
> abovementioned glibc patch, but which has an improved commit message; please 
> use it as a guideline for the glibc commit.

Fair enough, I indeed had changes commit message but I hadn't the trouble
to copied it on the message. I will use your suggestion.

> One more thing. Gnulib and other GNU projects are switching to using https: 
> URLs to gnu.org and to fsf.org, and this causes the shared glob sources to 
> differ in one line. Glibc should be fixed to use https: instead of http: for 
> citations to GNU and FSF web sites. That should be a separate patch, of 
> course. I'll look into it.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]