[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnulib-tool.py: Clean the imports

From: Mathieu Lirzin
Subject: Re: [PATCH] gnulib-tool.py: Clean the imports
Date: Sun, 24 Sep 2017 19:26:16 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

Hello Dmity,

Dmitry Selyutin <address@hidden> writes:

> thank you for this patch. While I'm impressed with the amount of work
> and appreciate the whole direction, I must admit that I'm going to
> rewrite the largest part of the original gnulib-tool.py. Once
> completed, the new implementation will make all these efforts and
> cleanups useless. Would you consider 'python' branch as the place for
> your Python work? As far as I know there is no need to do the same
> work as you did here, because all imports are correct and done as
> required by PEP8 and similar documents.

Sorry, I was unaware of that branch.  What about adding some information
about the gnulib-tool.py development process in a "README-hacking" file?

Since there is no "gnulib-tool.py" nor unit tests for the pygnulib
module in that branch how are you working on it? with the REPL?  Am I
overlooking something?

> Anyway, if you think that this patch is required, I can surely push
> it, it's absolutely OK from my point of view. But really, I would be
> glad if you could join the active development under 'python'
> branch. :-)

I would be happy to get involved in this development which will a good
excuse for improving my Python skills.

Given that the "python" branch seems like a full rewrite of the pygnulib
module, there is not much interest in applying my patch.


Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

reply via email to

[Prev in Thread] Current Thread [Next in Thread]