Re: [PATCH] Implement SM3 hash algorithm in gnulib and the computing tool in coreutils.

[Pádraig Brady]

On 10/10/17 23:58, 张佳(乾越) wrote:
> Hi,
> 
> This is the review request for SM3 hash algorithm. SM3 hash algorithm is
> already
> accepted and supported by TPM 2.0 spec. See page 284 in TPM 2.0 spec part 1
> (https://trustedcomputinggroup.org/wp-content/uploads/TPM-Rev-2.0-Part-1-Ar
> chitecture-01.38.pdf)
> 
> Currently, I only implement SM3 in gnulib. I will implement it in
> libgcrypt and
> openssl later.

> 
> Plz refer to the following PRs for code review.
> 
> - For the new gnulib module crypto/sm3
>   https://github.com/coreutils/gnulib/pull/3/commits
> 
> - For the new program sm3sum
>   https://github.com/coreutils/coreutils/pull/12/commits

I see the GMssl fork of openssl on github.
Has any attempt been made to merge with that project?
I'm not sure how generally useful a sm3sum command would be TBH.
Being available in gnulib is more plausible,
though I'd like to see it in the more specific openssl library first.
Why the specific need for an sm3sum command?
BTW you'd need to assign copyright for this to be merged to gnulib/coreutils.

thanks for taking the time to provide patches.

Pádraig