bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Implement SM3 hash algorithm in gnulib and the computing too


From: 张佳(乾越)
Subject: Re: [PATCH] Implement SM3 hash algorithm in gnulib and the computing tool in coreutils.
Date: Wed, 11 Oct 2017 16:05:30 +0800
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:24.0) Gecko/20100101 Thunderbird/24.3.0



于 2017/10/11 下午3:15, Pádraig Brady 写道:
On 10/10/17 23:58, 张佳(乾越) wrote:
Hi,

This is the review request for SM3 hash algorithm. SM3 hash algorithm is
already
accepted and supported by TPM 2.0 spec. See page 284 in TPM 2.0 spec part 1
(https://trustedcomputinggroup.org/wp-content/uploads/TPM-Rev-2.0-Part-1-Ar
chitecture-01.38.pdf)

Currently, I only implement SM3 in gnulib. I will implement it in
libgcrypt and
openssl later.


Plz refer to the following PRs for code review.

- For the new gnulib module crypto/sm3
   https://github.com/coreutils/gnulib/pull/3/commits

- For the new program sm3sum
   https://github.com/coreutils/coreutils/pull/12/commits

I see the GMssl fork of openssl on github.
Has any attempt been made to merge with that project?

I don't see GMssl keeps syncing up with the latest openssl so it is not
my goal.

I'm not sure how generally useful a sm3sum command would be TBH.
Being available in gnulib is more plausible,
though I'd like to see it in the more specific openssl library first.

If this is the prerequisite to merge sm3sum and crypto/sm3, I'll do it
later. But technically it is fine to compile sm3sum program without
openssl.

Why the specific need for an sm3sum command?

In some areas, SM3 algorithm is widely used, because SM3 algorithm has
additional strengthening features against sha256 at the cose of small
overhead increased.

BTW you'd need to assign copyright for this to be merged to gnulib/coreutils.

No problem. Is there anything to do for this?

Thanks,
Jia


thanks for taking the time to provide patches.

Pádraig




reply via email to

[Prev in Thread] Current Thread [Next in Thread]