[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 06/17] Regex: Use re_malloc / re_free consistently.

From: Paul Eggert
Subject: Re: [PATCH 06/17] Regex: Use re_malloc / re_free consistently.
Date: Tue, 19 Dec 2017 15:57:37 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0

On 12/08/2017 01:16 AM, Arnold Robbins wrote:
This patch changes several calls to malloc/free into re_malloc/re_free,
bringing consistency to the code.

Thanks, that patch makes sense, but it misses three opportunities to bring consistency. regcomp.c has one call each to malloc and free, which should be consistent too. Also, regexec.c has a call to realloc that should be be changed to re_realloc. A minor formatting issue: one newly-introduced re_malloc call doesn't need to appear on the next line.

(Possibly we should be adding consistency in the opposite way, by removing the macros re_free, re_malloc, and re_realloc, and simply using the underlying C functions. These macros are tricky since they are function-like but (aside from re_free) cannot be implemented as functions, and they don't buy much. But that'd be a bigger change.)

I installed the attached patch into Gnulib; it contains the originally proposed patch 06/17 along with the abovementioned fixups. Something like this should be easily installable into glibc.

Attachment: 0001-regex-use-re_malloc-etc.-consistently.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]