[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] fts: do not use the getcwdat module

From: Jim Meyering
Subject: Re: [PATCH 1/2] fts: do not use the getcwdat module
Date: Wed, 21 Mar 2018 16:12:59 -0700

On Wed, Mar 21, 2018 at 7:44 AM, Kamil Dudka <address@hidden> wrote:
> ... because there is no such module in gnulib
> ---
>  lib/fts.c | 26 +++++---------------------
>  1 file changed, 5 insertions(+), 21 deletions(-)
> diff --git a/lib/fts.c b/lib/fts.c
> index bfa73e31e..4195f6170 100644
> --- a/lib/fts.c
> +++ b/lib/fts.c
> @@ -253,7 +253,6 @@ static int      fts_safe_changedir (FTS *, FTSENT *, int, 
> const char *)
>  # include <inttypes.h>
>  # include <stdint.h>
>  # include <stdio.h>
> -# include "getcwdat.h"

Hi Kamil,
Thanks for noticing and fixing that.

It took some digging, but I found the code that I once used (back in
2006!) when I was building/testing that with -DFTS_DEBUG.
It was in a CVS-checked-out directory I had renamed to gnulib-corrupt.

I'll include those files here, for reference, in case someone wants to
modernize them and to make a module out of them -- they probably
predate gnulib's modules directory. Given that you're the first to
mention this in nearly 12 years, I suspect it's better just to forget
about these two files and use your patch, though I do recall
preferring to see actual directory names (rather than nearly useless
FDs) in debugging output. Another problem: getcwdat.c was essentially
copied from some old getcwd.c-related file; if we were to use this new
module, we'd probably require that the .c file be mechanically
derived, to avoid the duplication.

Attachment: getcwdat.c
Description: Binary data

Attachment: getcwdat.h
Description: Binary data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]