bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] acl-internal.h: remove _GL_ATTRIBUTE_CONST on void function


From: Jim Meyering
Subject: [PATCH] acl-internal.h: remove _GL_ATTRIBUTE_CONST on void function
Date: Mon, 25 Jun 2018 08:35:14 -0700

FYI, I saw another coreutils build failure when configured with
--enable-gcc-warnings and this addresses it:

>From ed78f0e059003680af6476989c39c9ba18ae3fd0 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Mon, 25 Jun 2018 08:28:12 -0700
Subject: [PATCH] acl-internal.h: remove _GL_ATTRIBUTE_CONST on void function

* lib/acl-internal.h (free_permission_context): Remove that
attribute directive.  Otherwise, it would provoke this from GCC 9:
lib/acl-internal.h:300:3: error: 'const' attribute on function \
  returning 'void' [-Werror=attributes]
---
 ChangeLog          | 8 ++++++++
 lib/acl-internal.h | 6 +-----
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 1ec489afa..610425917 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2018-06-25  Jim Meyering  <address@hidden>
+
+       acl-internal.h: remove _GL_ATTRIBUTE_CONST on void function
+       * lib/acl-internal.h (free_permission_context): Remove that
+       attribute directive.  Otherwise, it would provoke this from GCC 9:
+       lib/acl-internal.h:300:3: error: 'const' attribute on function \
+         returning 'void' [-Werror=attributes]
+
 2018-06-24  Jim Meyering  <address@hidden>

        parse-datetime: accommodate gcc-4.8.5
diff --git a/lib/acl-internal.h b/lib/acl-internal.h
index 6c65e65e5..0669d83c4 100644
--- a/lib/acl-internal.h
+++ b/lib/acl-internal.h
@@ -293,10 +293,6 @@ struct permission_context {

 int get_permissions (const char *, int, mode_t, struct permission_context *);
 int set_permissions (struct permission_context *, const char *, int);
-void free_permission_context (struct permission_context *)
-#if ! (defined USE_ACL && (HAVE_ACL_GET_FILE || defined GETACL))
-    _GL_ATTRIBUTE_CONST
-#endif
-  ;
+void free_permission_context (struct permission_context *);

 _GL_INLINE_HEADER_END
-- 
2.13.5




reply via email to

[Prev in Thread] Current Thread [Next in Thread]