[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ieee754-h: new module

From: Bruno Haible
Subject: Re: [PATCH] ieee754-h: new module
Date: Sat, 04 Aug 2018 16:04:54 +0200
User-agent: KMail/5.1.3 (Linux/4.4.0-130-generic; KDE/5.18.0; x86_64; ; )

Hi Paul,

> It looks like Emacs can use this for some NaN processing.
> Emacs uses it only on double NaNs so it should be safe.
> * MODULES.html.sh (func_all_modules): Add ieee754-h.
> * config/srclist.txt: Mention ieee754.h in a comment.
> * doc/glibc-headers/ieee754.texi (ieee754.h):
> Gnulib now has a substitute that should work
> except for long double and for non-IEEE platforms.

I'd like to improve the reliability of this module (when time

1) You say that Emacs wants it for NaN processing. But the unit
   tests don't test NaN values, only finite values.
   Suggested action: Add tests for NaN values.

2) There may be portability issues. I'm thinking of alpha CPUs,
   possibly also s390 CPUs.
   Suggested action: #ifdef out the definitions on platforms
   where they don't work. A compilation error is better than
   garbage at runtime.

3) There are definitions for 'long double', but they are untested.
   Suggested action: Add tests for 'long double'. #ifdef out the
   definitions on platforms where they don't work.

Would you approve work in these directions?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]