[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: New warnings on emacs-26 branch with gcc 8.2.0

From: Paul Eggert
Subject: Re: New warnings on emacs-26 branch with gcc 8.2.0
Date: Sat, 18 Aug 2018 10:19:54 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

Bruno Haible wrote:
This code uses GetProcAddress so that it can exploit
features of newer Windows versions while at the same time still
work on older Windows versions.

Can this problem be addressed a bit better by using GetProcAddress only inside #ifndef HAVE_GETSYSTEMTIMEPRECISEASFILETIME code on builds for MS-Windows 7 and earlier, and directly using GetSystemTimePreciseAsFileTime on builds for MS-Windows 8 and later? That should fix the warning on builds for newer MS-Windows, which might be good enough.

  3) Remove -Wcast-function-type from the compiler options.

If we do this in Emacs builds, it should be done only for MS-Windows since the warning is generally useful on other platforms.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]