[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Compilation error in glob.c with gcc 4.8

From: Reuben Thomas
Subject: Re: Compilation error in glob.c with gcc 4.8
Date: Sat, 18 Aug 2018 20:21:28 +0100

On 18 August 2018 at 08:57, Paul Eggert <address@hidden> wrote:
Reuben Thomas wrote:
Looks like lib/malloc/scratch_buffer.h needs to #include libc-config.h for
libc_hidden_proto? Only I can't quite believe it could be something so
simple for code that was last changed a while ago…

Does August 7 count as "a while ago"? Anyway, I suspect that caused the problem. I installed the attached which should fix things, albeit more drastically than I'd like as it creates glob.h in cases where it's not needed.

Thanks! I was assuming the problem was in lib/malloc/scratch_buffer.h, which it seems should include libc-config.h; there's a similar problem in glob_pattern_p.c.

I attach the patches I used to fix it. I'm interested to know, if they're misguided, why so, as the fault seemed pretty obvious to me.


Attachment: glob_pattern_p.c.diff
Description: Text Data

Attachment: scratch_buffer.h.diff
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]