[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Compilation error in glob.c with gcc 4.8

From: Bruno Haible
Subject: Re: Compilation error in glob.c with gcc 4.8
Date: Sat, 18 Aug 2018 21:45:13 +0200
User-agent: KMail/5.1.3 (Linux/4.4.0-130-generic; KDE/5.18.0; x86_64; ; )

Paul Eggert wrote:
> I didn't think the patch would be controversial

... whereas I would think that every revert or partial revert is controversial
(except for obvious typos).

> Please feel free to 
> revert the patch and replace it with something better.

Done as follows:
  - I added a small test module 'scratch_buffer-tests'. It showed the same
    errors as reported by Reuben.
  - The I inserted '#include <libc-config.h>' in scratch_buffer.h. The errors
    went away.

Reuben, could you please verify that it fixes the issue with glob.c in your
situation? Thanks.

2018-08-18  Bruno Haible  <address@hidden>

        scratch_buffer: Add tests.
        * tests/test-scratch-buffer.c: New file.
        * modules/scratch_buffer-tests: New file.

2018-08-18  Bruno Haible  <address@hidden>

        scratch_buffer: Fix include file.
        Reported by Reuben Thomas <address@hidden> in
        * lib/scratch_buffer.h: Include <libc-config.h> first. Add
        double-inclusion guard.

2018-08-18  Bruno Haible  <address@hidden>

        glob-h: Revert Paul Eggert's revert.
        * m4/glob_h.m4: Revert to previous state.
        * modules/glob-h: Likewise.

Attachment: 0001-glob-h-Revert-Paul-Eggert-s-revert.patch
Description: Text Data

Attachment: 0002-scratch_buffer-Fix-include-file.patch
Description: Text Data

Attachment: 0003-scratch_buffer-Add-tests.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]