[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Compilation error in glob.c with gcc 4.8

From: Reuben Thomas
Subject: Re: Compilation error in glob.c with gcc 4.8
Date: Sat, 18 Aug 2018 20:56:08 +0100

On 18 August 2018 at 20:45, Bruno Haible <address@hidden> wrote:
Paul Eggert wrote:
> I didn't think the patch would be controversial

... whereas I would think that every revert or partial revert is controversial
(except for obvious typos).

> Please feel free to
> revert the patch and replace it with something better.

Done as follows:
  - I added a small test module 'scratch_buffer-tests'. It showed the same
    errors as reported by Reuben.
  - The I inserted '#include <libc-config.h>' in scratch_buffer.h. The errors
    went away.

Reuben, could you please verify that it fixes the issue with glob.c in your
situation? Thanks.

This makes the build break again because of the problem I reported in glob_pattern_p.c (see my patch for it).

reply via email to

[Prev in Thread] Current Thread [Next in Thread]