[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: _WIN32 and __CYGWIN__

From: Ken Brown
Subject: Re: _WIN32 and __CYGWIN__
Date: Sun, 16 Sep 2018 18:02:58 -0400
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

Hi Bruno,

On 9/16/2018 5:37 PM, Bruno Haible wrote:
Hi Ken,

The '! defined __CYGWIN__' part is redundant,
because _WIN32 is never defined on Cygwin.

No. _WIN32 is not defined _by_default_ on Cygwin. But users can use
"gcc -D_WIN32", when they want to access native Windows APIs (for
whatever reason).

In fact, you can see from [1] that up until two weeks ago, the normal
way to build libxml2 on Cygwin was with -D_WIN32.

I'm not sure what you mean by "normal". The build for the Cygwin distribution does not use -D_WIN32 and never has, AFAIK.

Otherwise, why would
people have written '#if defined(_WIN32) && defined(__CYGWIN__)' ?

I can't know without looking back at the history, but my best guess is that it was simply a mistake, which was fixed by the commit you pointed to. The commit message strongly suggests this, in my opinion.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]