[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] hmac-*: refactor to remove repetitive code
|
From: |
Bruno Haible |
|
Subject: |
Re: [PATCH 2/2] hmac-*: refactor to remove repetitive code |
|
Date: |
Sun, 30 Sep 2018 20:22:48 +0200 |
|
User-agent: |
KMail/5.1.3 (Linux/4.4.0-134-generic; KDE/5.18.0; x86_64; ; ) |
Hi Pádraig,
With this patch, I see a small regression:
> #include <config.h>
> -
> -#include "hmac.h"
and
> --- a/tests/test-hmac-sha1.c
> +++ b/tests/test-hmac-sha1.c
> @@ -17,43 +17,51 @@
> /* Written by Simon Josefsson. */
>
> #include <config.h>
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <string.h>
>
> #include "hmac.h"
There is no verification any more that hmac.h is self-contained.
As mentioned just yesterday, the best practice is to #include the
specification header right after <config.h>.
Bruno