[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: memory leaks in gnulib tests (for ASAN/LINT)

From: Bruno Haible
Subject: Re: memory leaks in gnulib tests (for ASAN/LINT)
Date: Thu, 11 Oct 2018 01:51:36 +0200
User-agent: KMail/5.1.3 (Linux/4.4.0-137-generic; KDE/5.18.0; x86_64; ; )

Hi Assaf,

> In this specific case, the fix is rather simple and costs very little.
> would you consider it?


But I don't like the '#ifdef lint' lines. Unit tests are not optimized
for speed. Instead, I find it useful to not multiply the number of
possible configurations of the tests (with and without -O2, in VPATH
dir or not, now also with or without -Dlint, ...).

May I remove these '#ifdef lint' and still commit it under your name?

> With it, sed and sed's gnulib testsuite passes all tests under SASN,
> which is a nice bonus

Does sed's test suite also pass with NLS enabled, in a locale other
than the "C" or an English locale, without harmless memory leaks?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]