[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Fwd: [PATCH] maintainer-makefile: fix syntax-check rule for "same.h" [wa

From: Bernhard Voelker
Subject: Fwd: [PATCH] maintainer-makefile: fix syntax-check rule for "same.h" [was: [INSTALLED 2/2] ln: use linkat and symlinkat]
Date: Sun, 28 Oct 2018 13:21:53 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

sorry, I forgot to include bug-gnulib, sending again ...
For reference, the original change in coreutils was published here:

On 10/28/18 9:48 AM, Paul Eggert wrote:
> @@ -291,7 +269,8 @@ do_link (const char *source, const char *dest, int 
> link_errno)
>                    if (source_status == 0
>                        && SAME_INODE (source_stats, dest_stats)
>                        && (source_stats.st_nlink == 1
> -                          || same_name (source, dest)))
> +                          || same_nameat (AT_FDCWD, source,
> +                                          destdir_fd, dest_base)))

This change leads leads to a FP syntax-check failure:

  $ make syntax-check
  maint.mk: the above files include same.h but don't use it
  make: *** [maint.mk:575: sc_prohibit_same_without_use] Error 1

The attached gnulib patch fixes the SC rule - pls. check.

Thanks & have a nice day,

Attachment: 0001-maintainer-makefile-fix-syntax-check-rule-for-same.h.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]