bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bootstrap: clean only gnulib's stray links


From: Jim Meyering
Subject: Re: bootstrap: clean only gnulib's stray links
Date: Fri, 4 Jan 2019 07:56:37 -0800

On Fri, Jan 4, 2019 at 7:42 AM Akim Demaille <address@hidden> wrote:
...
> > Le 2 janv. 2019 à 06:27, Jim Meyering <address@hidden> a écrit :
> >
> > Hi Akim,
> >
> > My only concern is that `pwd` may sometimes fail to match the link
> > name when it should. E.g., when mount points or directory symlinks are
> > involved.
> >
> > Instead, can you simply make the bootstrap script fail when the
> > submodules are not initialized?
>
> Simpler, safer, better, en un mot, Meyer :-)

:-)
...
> +       bootstrap: die when some submodules are not initialized
> +       * build-aux/bootstrap: Make sure all submodules are initialized.
...
> +# Don't proceed if there are non-initialized submodules.  In
> +# particular, the next step will remove dangling links, which might be
> +# links into non-initialized submodules.
> +#
> +# Non-initialized submodules are listed with an initial dash.
> +if $use_git && git submodule | grep '^-' >/dev/null; then
> +  die "some git submodules are not initialized. "     \
> +      "Run 'git submodule init' and bootstrap again."
> +fi

Looks fine to me.
comment nit: s/non-initialized/uninitialized/

Thanks!

et bonne année!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]