[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
fix incorrect 'Link' sections
From: |
Bruno Haible |
Subject: |
fix incorrect 'Link' sections |
Date: |
Fri, 04 Jan 2019 20:26:48 +0100 |
User-agent: |
KMail/5.1.3 (Linux/4.4.0-141-generic; KDE/5.18.0; x86_64; ; ) |
Another incorrect 'Link' section is the one in the 'regex' module:
- It needs to inherit the link directive from the 'lock' module.
This is needed on AIX 7 (and probably on HP-UX 11.11, see the
earlier report [1][2]).
- It also needs a reference to libintl. (Reported in [3].)
Paul's patch in response to [1][2] fixed the regex-tests module.
The $(LIB_PTHREAD) addition, however, is redundant: None of the
dependencies of the 'regex-tests' module sets a LIB_PTHREAD variable;
therefore this reference expands to empty.
[1] http://lists.gnu.org/archive/html/bug-gnulib/2013-10/msg00052.html
[2] http://lists.gnu.org/archive/html/bug-gnulib/2013-10/msg00054.html
[3] http://lists.gnu.org/archive/html/bug-gnulib/2013-02/msg00003.html
2019-01-04 Bruno Haible <address@hidden>
Fix incorrect 'Link' sections.
* modules/regex (Link): Mention the link requirement of module 'lock'.
* modules/regex-tests (Makefile.am): Don't use LIB_PTHREAD.
diff --git a/modules/regex b/modules/regex
index 278510c..7f50916 100644
--- a/modules/regex
+++ b/modules/regex
@@ -48,6 +48,7 @@ Include:
<regex.h>
Link:
+$(LTLIBTHREAD) when linking with libtool, $(LIBTHREAD) otherwise
$(LTLIBINTL) when linking with libtool, $(LIBINTL) otherwise
License:
diff --git a/modules/regex-tests b/modules/regex-tests
index 30ca5fd..0782303 100644
--- a/modules/regex-tests
+++ b/modules/regex-tests
@@ -11,4 +11,4 @@ configure.ac:
Makefile.am:
TESTS += test-regex
check_PROGRAMS += test-regex
-test_regex_LDADD = $(LDADD) @LIBINTL@ $(LIBTHREAD) $(LIB_PTHREAD)
+test_regex_LDADD = $(LDADD) @LIBINTL@ $(LIBTHREAD)
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- fix incorrect 'Link' sections,
Bruno Haible <=