[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: test-rwlock1 failing on latest Fedora Rawhide
From: |
Bruno Haible |
Subject: |
Re: test-rwlock1 failing on latest Fedora Rawhide |
Date: |
Thu, 24 Jan 2019 04:49:57 +0100 |
User-agent: |
KMail/5.1.3 (Linux/4.4.0-141-generic; KDE/5.18.0; x86_64; ; ) |
> (2) threadlib.m4 defines LIBMULTITHREAD in a way that is meant to defeat
> -Wl,--as-needed. But it does not work, due to the reordering of
> options done by libtool.
Let me take out the code that does not work.
2019-01-23 Bruno Haible <address@hidden>
threadlib: Revert commit from 2018-06-25. We now have a better fix.
* m4/threadlib.m4 (gl_THREADLIB_BODY): Don't attempt to defeat a
preceding -Wl,--as-needed option. Don't check whether the linker
supports --as-needed/--no-as-needed and --push-state/--pop-state.
diff --git a/m4/threadlib.m4 b/m4/threadlib.m4
index f7841b6..bfc3bac 100644
--- a/m4/threadlib.m4
+++ b/m4/threadlib.m4
@@ -1,4 +1,4 @@
-# threadlib.m4 serial 15
+# threadlib.m4 serial 16
dnl Copyright (C) 2005-2019 Free Software Foundation, Inc.
dnl This file is free software; the Free Software Foundation
dnl gives unlimited permission to copy and/or distribute it,
@@ -151,36 +151,6 @@ int main ()
*" -static "*) gl_cv_have_weak=no ;;
esac
])
- dnl Check whether the linker supports the --as-needed/--no-as-needed
options.
- dnl Assume GCC, so that we can use the -Wl option.
- AC_CACHE_CHECK([whether the linker supports --as-needed],
- [gl_cv_linker_have_as_needed],
- [if test -n "$GCC"; then
- gl_saved_ldflags="$LDFLAGS"
- LDFLAGS="$gl_saved_ldflags -Wl,--as-needed -Wl,--no-as-needed"
- AC_LINK_IFELSE([AC_LANG_PROGRAM()],
- [gl_cv_linker_have_as_needed=yes],
- [gl_cv_linker_have_as_needed=no])
- LDFLAGS="$gl_saved_ldflags"
- else
- gl_cv_linker_have_as_needed=no
- fi
- ])
- dnl Check whether the linker supports the --push-state/--pop-state options.
- dnl Assume GCC, so that we can use the -Wl option.
- AC_CACHE_CHECK([whether the linker supports --push-state],
- [gl_cv_linker_have_push_state],
- [if test -n "$GCC"; then
- gl_saved_ldflags="$LDFLAGS"
- LDFLAGS="$gl_saved_ldflags -Wl,--push-state -Wl,--pop-state"
- AC_LINK_IFELSE([AC_LANG_PROGRAM()],
- [gl_cv_linker_have_push_state=yes],
- [gl_cv_linker_have_push_state=no])
- LDFLAGS="$gl_saved_ldflags"
- else
- gl_cv_linker_have_push_state=no
- fi
- ])
if test "$gl_use_threads" = yes || test "$gl_use_threads" = posix; then
# On OSF/1, the compiler needs the flag -pthread or -D_REENTRANT so that
# it groks <pthread.h>. It's added above, in gl_THREADLIB_EARLY_BODY.
@@ -259,32 +229,6 @@ int main ()
[Define if references to the POSIX multithreading library
should be made weak.])
LIBTHREAD=
LTLIBTHREAD=
- dnl On platforms where GCC enables --as-needed by default,
attempt
- dnl to make sure that LIBMULTITHREAD really links with -lpthread.
- dnl Otherwise linking with LIBMULTITHREAD has no effect; then
- dnl the weak symbols are not defined and thus evaluate to NULL.
- case "$LIBMULTITHREAD" in
- "") ;;
- -pthread)
- if test $gl_cv_linker_have_as_needed = yes; then
- if test $gl_cv_linker_have_push_state = yes; then
- LIBMULTITHREAD="$LIBMULTITHREAD -Wl,--push-state
-Wl,--no-as-needed -lpthread -Wl,--pop-state"
- else
- LIBMULTITHREAD="$LIBMULTITHREAD -Wl,--no-as-needed
-lpthread"
- fi
- fi
- ;;
- *)
- if test $gl_cv_linker_have_as_needed = yes; then
- if test $gl_cv_linker_have_push_state = yes; then
- LIBMULTITHREAD="-Wl,--push-state -Wl,--no-as-needed
$LIBMULTITHREAD -Wl,--pop-state"
- else
- LIBMULTITHREAD="-Wl,--no-as-needed $LIBMULTITHREAD"
- fi
- fi
- ;;
- esac
- # TODO: May need to modify LTLIBMULTITHREAD similarly.
fi
fi
fi
@@ -317,18 +261,6 @@ int main ()
[Define if references to the old Solaris multithreading library
should be made weak.])
LIBTHREAD=
LTLIBTHREAD=
- dnl On platforms where GCC enables --as-needed by default, attempt
- dnl to make sure that LIBMULTITHREAD really links with -lthread.
- dnl Otherwise linking with LIBMULTITHREAD has no effect; then
- dnl the weak symbols are not defined and thus evaluate to NULL.
- if test $gl_cv_linker_have_as_needed = yes; then
- if test $gl_cv_linker_have_push_state = yes; then
- LIBMULTITHREAD="-Wl,--push-state -Wl,--no-as-needed
$LIBMULTITHREAD -Wl,--pop-state"
- else
- LIBMULTITHREAD="-Wl,--no-as-needed $LIBMULTITHREAD"
- fi
- fi
- # TODO: May need to modify LTLIBMULTITHREAD similarly.
fi
fi
fi
@@ -357,18 +289,6 @@ int main ()
[Define if references to the GNU Pth multithreading library
should be made weak.])
LIBTHREAD=
LTLIBTHREAD=
- dnl On platforms where GCC enables --as-needed by default, attempt
- dnl to make sure that LIBMULTITHREAD really links with -lpth.
- dnl Otherwise linking with LIBMULTITHREAD has no effect; then
- dnl the weak symbols are not defined and thus evaluate to NULL.
- if test $gl_cv_linker_have_as_needed = yes; then
- if test $gl_cv_linker_have_push_state = yes; then
- LIBMULTITHREAD="-Wl,--push-state -Wl,--no-as-needed
$LIBMULTITHREAD -Wl,--pop-state"
- else
- LIBMULTITHREAD="-Wl,--no-as-needed $LIBMULTITHREAD"
- fi
- fi
- # TODO: May need to modify LTLIBMULTITHREAD similarly.
fi
fi
else
- Re: test-rwlock1 failing on latest Fedora Rawhide, (continued)
- Re: test-rwlock1 failing on latest Fedora Rawhide, Bruno Haible, 2019/01/23
- Re: test-rwlock1 failing on latest Fedora Rawhide, Richard W.M. Jones, 2019/01/23
- Re: test-rwlock1 failing on latest Fedora Rawhide, Dmitry V. Levin, 2019/01/23
- Re: test-rwlock1 failing on latest Fedora Rawhide, Michael Hudson-Doyle, 2019/01/23
- Re: test-rwlock1 failing on latest Fedora Rawhide, Richard W.M. Jones, 2019/01/23
- Re: test-rwlock1 failing on latest Fedora Rawhide, Dmitry V. Levin, 2019/01/23
- Re: test-rwlock1 failing on latest Fedora Rawhide, Richard W.M. Jones, 2019/01/23
- Re: test-rwlock1 failing on latest Fedora Rawhide, Dmitry V. Levin, 2019/01/23
- Re: test-rwlock1 failing on latest Fedora Rawhide, Bruno Haible, 2019/01/23
- Re: test-rwlock1 failing on latest Fedora Rawhide, Bruno Haible, 2019/01/23
- Re: test-rwlock1 failing on latest Fedora Rawhide,
Bruno Haible <=
- Re: test-rwlock1 failing on latest Fedora Rawhide, Richard W.M. Jones, 2019/01/24
- Re: test-rwlock1 failing on latest Fedora Rawhide, Richard W.M. Jones, 2019/01/24