bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] regex: Add extra escapes to regular expressions in m4


From: Siddhesh Poyarekar
Subject: Re: [PATCH] regex: Add extra escapes to regular expressions in m4
Date: Wed, 30 Jan 2019 07:53:26 +0530
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1

On 30/01/19 2:16 AM, Eric Blake wrote:
> Looking at m4/fnmatch.m4, it looks like we are already used to the idea
> of doubling up \\ that will pass through AC_LANG_PROGRAM() and the
> unquoted heredoc; on that grounds, your patch is correct.

Sorry yes, it's the shell that's eating up the backslashes; I basically
compared the generated conftest.c and tests/test-regex.c to check if
both programs had the same regex and they didn't.  Is it OK to commit
this oatchpatch or would you like me to make any additional changes
beyond changing the commit message?

Thanks,
Siddhesh

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]