[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Gnulib's alloca.h used even when there is a system header
From: |
Bruno Haible |
Subject: |
Re: Gnulib's alloca.h used even when there is a system header |
Date: |
Sun, 10 Mar 2019 20:54:20 +0100 |
User-agent: |
KMail/5.1.3 (Linux/4.4.0-141-generic; KDE/5.18.0; x86_64; ; ) |
Eli Zaretskii wrote:
> It LGTM, since I already succeeded to build that package with this:
Thanks for the confirmation.
> > +# if (defined _WIN32 && ! defined __CYGWIN__) && @HAVE_ALLOCA_H@
>
> replaced by just "#if HAVE_ALLOCA_H"
Right, AC_FUNC_ALLOCA already defines HAVE_ALLOCA_H as a preprocessor
macro, under the same conditions. But we have the habit, when we
create a .h file from a .in.h file, to substitute values found at
configure time directly. This
- makes it possible to reference the same variables in the
module description,
- increases the probability that the .h file works even when the
user has forgotten to #include <config.h> or adds or removes
a macro definition through #define or #undef,
- increases transparency in case of a compilation error.
Pushed.
Bruno