bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Why does close_stdout close stdout and stderr?


From: Bernhard Voelker
Subject: Re: Why does close_stdout close stdout and stderr?
Date: Mon, 6 May 2019 16:56:41 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

On 5/6/19 2:05 PM, Florian Weimer wrote:
>>> On 4/29/19 2:45 PM, Florian Weimer wrote:
>>>> I get that error checking is important.  But why not just use ferror and
>>>> fflush?  Closing the streams is excessive and tends to introduce
>>>> use-after-free issues, as evidenced by the sanitizer workarounds.

> This means that for Linux at least, close_stdout should just call
> fflush, not fclose.

What is the problem?  I mean if it is use-after-free as mentioned in
the first mail, then write() after fflush() without error checking via
another fflush() is in the same category, isn't it?

Have a nice day,
Berny




reply via email to

[Prev in Thread] Current Thread [Next in Thread]