bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: argmatch: accept perfect matches in documented arglists


From: Bruno Haible
Subject: Re: argmatch: accept perfect matches in documented arglists
Date: Sun, 19 May 2019 18:13:06 +0200
User-agent: KMail/5.1.3 (Linux/4.4.0-145-generic; KDE/5.18.0; x86_64; ; )

Hi Akim,

> What do you think of something like this?

Looks very nice.

Now, can the aforementioned issue with the existing argmatch() interface
be solved in the same way?

> +#include <gettext.h>
> +#include <stdbool.h>
> +#include <string.h> /* memcmp */

These includes, IMO, belong in the argmatch.h file, not in each program that 
uses
the ARGMATCH_DEFINE_GROUP macro.

Also, for the use of 'static inline', you need an AC_REQUIRE([AC_C_INLINE]) in
the module description.

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]