bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: argmatch: accept perfect matches in documented arglists


From: Akim Demaille
Subject: Re: argmatch: accept perfect matches in documented arglists
Date: Sun, 19 May 2019 18:52:59 +0200

> Le 19 mai 2019 à 18:37, Paul Eggert <address@hidden> a écrit :
> 
> Bruno Haible wrote:
>> Also, for the use of 'static inline', you need an AC_REQUIRE([AC_C_INLINE]) 
>> in
>> the module description.
> 
> Better to avoid the use of the 'inline' keyword there. These days I suggest 
> avoiding 'inline' as compilers are pretty good at inlining automatically and 
> it's often not worth the hassle of human annotation. 'inline' has its uses 
> but this particular place isn't one of them.

I have no opinion about this, I just matched things I saw in gnulib.

Actually, if it were C++, I would use only "inline", as it makes the symbol 
weak and forces the linker to keep a single copy.  "static inline" would be 
nonsensical, and "inline" superior to "static" (which duplicates).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]