Re: [PATCH] binary-io: do not treat set_binary_mode() on stdin/out/err as an error on OS/2

[Paul Eggert]

On 5/24/19 4:31 AM, KO Myung-Hun wrote:
> Setting stdin/out/err to binary mode is allowed on OS/2. But it's not
> useful, because it generates stair-output hard to read.
>
> Instead, let's set them to text mode all the time.

First, that patch doesn't set them to text mode all the time; it does so 
only if isatty returns nonzero.

Second, __gl_setmode_check already has the isatty test, so why do it twice?