bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: new modules for looking up the ancestors of a process


From: Bernhard Voelker
Subject: Re: new modules for looking up the ancestors of a process
Date: Wed, 14 Aug 2019 07:58:03 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

On 8/14/19 2:05 AM, Bruno Haible wrote:
> diff --git a/modules/get_progname_of b/modules/get_progname_of
> new file mode 100644
> index 0000000..012cc59
> --- /dev/null
> +++ b/modules/get_progname_of
> @@ -0,0 +1,24 @@
> +Description:
> +Determine the program name of a given process.
> +
> +Files:
> +lib/get_progname_of.h
> +lib/get_progname_of.c
> +
> +Depends-on:
> +extensions
> +unistd
> +
> +configure.ac:
> +
> +Makefile.am:
> +lib_SOURCES += get_progname_of.h get_progname_of.c
> +
> +Include:
> +"get_progname_of.h"
> +
> +License:
> +LGPL
> +
> +Maintainer:
> +all

Nice work, thanks.

Nits:
I'd document that the caller has to free the returned memory later;
so at least here in the module description, but maybe also in the
header and - as it serves as example code - in the test.

Have a nice day,
Berny



reply via email to

[Prev in Thread] Current Thread [Next in Thread]