[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

install-sh -s on readonly file

From: Karl Berry
Subject: install-sh -s on readonly file
Date: Sun, 25 Aug 2019 18:52:45 -0600

Hi - I sent this possible patch for install-sh to bug-automake
(https://debbugs.gnu.org/cgi/bugreport.cgi?bug=36966, appended below for
convenience).  My fix seems clunky to me, but neither Jim nor I could
think of a better way and there were no replies on the list.  I just
thought I'd send it here to see if anyone had any ideas before we
install it ... --thanks, karl.

From: Karl Berry <address@hidden>
To: address@hidden
Subject: install-sh -s on 555 executable fails

(I'm not on this list, so please keep me in cc if need be.)

It seems that install-sh -s (what automake's install-strip target can
end up doing) fails if the original file doesn't have the owner-write
bit set:

cp /bin/cp /tmp/rx            # any binary will do
chmod 555 /tmp/rx             # make unwritable to owner
install-sh -s /tmp/rx /tmp/sx # try to install, with strip
-> strip: unable to copy file '/tmp/_inst.31092_'; reason: Permission denied
echo $?
-> 1

Although install-sh (version 2018-03-11.20, lines 224ff.) does some
stuff to ensure that umask will not clear an owner-writable bit in the
destination, that's not enough to make it owner-writable if it's not

The only less-than-wonderful fix I could come up with is to explicitly
do chmod u+w if strip is being executed. I thought maybe it would be
worth trying the strip even if the chmod failed, hence the ; instead of
&&, but it's not something I feel strongly about. And maybe there is
some nicer way to do it altogether.

--- a/build-aux/install-sh
+++ b/build-aux/install-sh
@@ -461,7 +461,7 @@ do
     { test -z "$chowncmd" || $doit $chowncmd "$dsttmp"; } &&
     { test -z "$chgrpcmd" || $doit $chgrpcmd "$dsttmp"; } &&
-    { test -z "$stripcmd" || $doit $stripcmd "$dsttmp"; } &&
+    { test -z "$stripcmd" || ($doit $chmodcmd u+w "$dsttmp"; $doit $stripcmd 
"$dsttmp") } &&
     { test -z "$chmodcmd" || $doit $chmodcmd $mode "$dsttmp"; } &&
     # If -C, don't bother to copy if it wouldn't change the file.

Wdyt? --thanks, karl.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]