bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Change http: to https: and update URLs


From: Paul Eggert
Subject: Re: Change http: to https: and update URLs
Date: Mon, 23 Sep 2019 12:48:56 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0

On 9/23/19 3:01 AM, Bruno Haible wrote:

There are a few nits, though:
   * http://www.w3.org/TR/html401/loose.dtd is not a URL; it's a declaration.

Thanks, that should be fixed in the attached patch.

   * I don't find it adequate to remove comments in
       lib/creat.c
       lib/fopen.c
       lib/open.c
       lib/openat.c
       tests/test-fflush2.c
     I mean, just pointing to a 13-page long document
       https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap04.html
     as a rationale for some small technical decision really obscures the
     technical argument.

True, however the problem was the POSIX wording got considerably longer, and at some point the lengthy comment was going to be more trouble than it was worth. I attempted to fix this in the attached patch by paraphrasing rather than quoting, and by using an id in the URL to point to the relevant section of the document. The test-fflush2 URL should point to the POSIX fflush spec, which I hope is enough.

   * What happened to point 3 in lib/fflush.c?

It was supposed to be subsumed into point 2, since we can now refer to the updated POSIX rather than to the old POSIX plus an Austin bug report. However, I didn't subsume it well, since this is fflush.c so the comment should cite the fflush spec rather than the ungetc spec. I attempted to fix this in the attached patch.

Thanks for the careful review, and feel free to further improve the citations, wording, quoting, etc.

Attachment: 0001-Update-URLs-and-associated-text.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]