bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] stdlib: avoid canonicalize_file_name contradiction


From: Jim Meyering
Subject: Re: [PATCH] stdlib: avoid canonicalize_file_name contradiction
Date: Sun, 5 Jan 2020 08:46:12 -0800

On Sun, Jan 5, 2020 at 8:41 AM Jim Meyering <address@hidden> wrote:
...
> > Does the attached patch fix the problem for you?
>
> Thanks for working on that. However, it did not help, because at least
> on Fedora 30, we're using the system declaration, per this: (run from
> a test dir prepared by "./gnulib-tool --test --dir /tmp/x --with-tests
> canonicalize-lgpl", which still segfaults that test)
>
> $ rm test-canonicalize-lgpl.o
> $ make test-canonicalize-lgpl.o CFLAGS='-dD -E'
> ...
> $ grep -A2 ze_file test-canonicalize-lgpl.o|head -3
> extern char *canonicalize_file_name (const char *__name)
>      __attribute__ ((__nothrow__ , __leaf__)) __attribute__
> ((__nonnull__ (1))) ;
> # 797 "/usr/include/stdlib.h" 3 4

This makes me suspect I did not test my own patch.
I've just confirmed that. My patch didn't help, either.
Sorry about that.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]