[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
filename.h and dosname.h define identical macros
From: |
Tim Rühsen |
Subject: |
filename.h and dosname.h define identical macros |
Date: |
Tue, 17 Mar 2020 09:53:18 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
Hi,
dosname.h (included by dirname.h) and filename.h overlap in macro
definition. This currently results in an error here:
In file included from wget.c:61:
In file included from ../lib/dirname.h:24:
../lib/dosname.h:36:10: error: 'FILE_SYSTEM_PREFIX_LEN' macro redefined
[-Werror,-Wmacro-redefined]
# define FILE_SYSTEM_PREFIX_LEN(Filename) 0
^
../lib/filename.h:46:10: note: previous definition is here
# define FILE_SYSTEM_PREFIX_LEN(P) 0
^
1 error generated.
make[2]: *** [Makefile:1737: wget.o] Error 1
We can easily work-around or even ignore this on our side.
But maybe it's time to consolidate the code, as we have e.g.
_IS_DRIVE_LETTER(C) and HAS_DEVICE(P) doing the same with slightly
different implementations ?
Regards, Tim
signature.asc
Description: OpenPGP digital signature
- filename.h and dosname.h define identical macros,
Tim Rühsen <=