bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Remove license modules


From: Asher Gordon
Subject: Re: Remove license modules
Date: Sun, 17 May 2020 15:58:54 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Hi Bruno,

Bruno Haible <address@hidden> writes:

>> I also fixed a minor issue where "VCS" ended with
>> "." rather than "@." (see (texinfo) Ending a Sentence).
>
> I won't spend time on a single instance of this very minor issue. But if
> you want to submit a patch that fixes all instances of this issue, I'll
> appreciate it.

See the attached 0001-doc-Change-.-to-.-where-appropriate.patch. It
turns out that there were quite a few instances that should be changed,
but nothing that 'dired-do-find-regexp-and-replace' couldn't
handle. Since there were so many changed files, I wasn't sure if I
should list them all. What I did was list them in the ChangeLog, but not
in the commit message. Feel free to change that if you like.

Also, there were some '.'s that should be changed to '@.' in the license
Texinfo files. I'm not sure what the procedure would be for changing
those, and we might even have to wait for the next release of those
licenses. So I haven't included those changes in the main patch, but
I've attached another patch, licenses.patch, to fix the licenses.

Perhaps Texinfo should change its heuristics so that a '.' preceding a
capital letter always starts a sentence, even when it is preceded by a
capital letter. I think that would do the right thing more often than
the current heuristics. I'll propose that to the Texinfo maintainers and
see what they say. You might want to hold off on the patch I attached
until I hear back from the Texinfo maintainers.

> +Notice:
> +Don't use this module! Instead, copy the referenced license file into your 
> version control repository.
> +

As Ineiev said, it is valid to use these modules as long as the files
are included in version control. So you might want to change the
notice. But then again, even if a project does normally keep all Gnulib
files under version control, the license modules still wouldn't be very
useful since the license text rarely changes.

Thanks,
Asher

-- 
One picture is worth 128K words.

GPG fingerprint: 38F3 975C D173 4037 B397  8095 D4C9 C4FC 5460 8E68

Attachment: 0001-doc-Change-.-to-.-where-appropriate.patch
Description: Change '.' to '@.' where appropriate.

Attachment: licenses.patch
Description: Do the same for the license files.

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]