[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] read-file: add variants that clear internal memory
From: |
Daiki Ueno |
Subject: |
Re: [PATCH] read-file: add variants that clear internal memory |
Date: |
Wed, 27 May 2020 14:18:07 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Bruno Haible <address@hidden> writes:
> The first one is nearly perfect. Only the NEWS entry should go into section
> "User visible incompatible changes", not into section "Important general
> notes".
>
> The second one:
> - In fread_file, around line 100, you use a realloc workaround that appears
> to be not as reliable as the malloc+free based workaround around line 135.
> - In read_file, please don't use tabs for indentation. We've switched to
> spaces-only indentation long ago.
>
> Once this is fixed, please push.
Both has been fixed and pushed. Thank you for the review!
Regards,
--
Daiki Ueno
- [PATCH] read-file: add variants that clear internal memory, Daiki Ueno, 2020/05/26
- Re: [PATCH] read-file: add variants that clear internal memory, Bruno Haible, 2020/05/26
- Re: [PATCH] read-file: add variants that clear internal memory, Daiki Ueno, 2020/05/26
- Re: [PATCH] read-file: add variants that clear internal memory, Bruno Haible, 2020/05/26
- Re: [PATCH] read-file: add variants that clear internal memory, Daiki Ueno, 2020/05/27
- Re: [PATCH] read-file: add variants that clear internal memory, Bruno Haible, 2020/05/27
- Re: [PATCH] read-file: add variants that clear internal memory,
Daiki Ueno <=
- Re: [PATCH] read-file: add variants that clear internal memory, Bruno Haible, 2020/05/28
- Re: [PATCH] read-file: add variants that clear internal memory, Daiki Ueno, 2020/05/28
- Re: [PATCH] read-file: add variants that clear internal memory, Bruno Haible, 2020/05/29
- Re: [PATCH] read-file: add variants that clear internal memory, Daiki Ueno, 2020/05/29