>From 54e5d001797c755994968a34259bae745ee515e6 Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Tue, 26 May 2020 17:56:31 +0200 Subject: [PATCH 4/8] getpass: Make more robust in multithreaded applications. * lib/getpass.c (getpass): Pass an 'e' flag to fopen. * modules/getpass (Depends-on): Add fopen-gnu. --- ChangeLog | 6 ++++++ lib/getpass.c | 2 +- modules/getpass | 1 + 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 7dabc5e..93d8b5a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,11 @@ 2020-05-26 Bruno Haible + getpass: Make more robust in multithreaded applications. + * lib/getpass.c (getpass): Pass an 'e' flag to fopen. + * modules/getpass (Depends-on): Add fopen-gnu. + +2020-05-26 Bruno Haible + getloadavg: Make more robust in multithreaded applications. * lib/getloadavg.c (getloadavg): Pass an 'e' flag to fopen. * modules/getloadavg (Depends-on): Add fopen-gnu. diff --git a/lib/getpass.c b/lib/getpass.c index af8d72e..3b0552e 100644 --- a/lib/getpass.c +++ b/lib/getpass.c @@ -96,7 +96,7 @@ getpass (const char *prompt) /* Try to write to and read from the terminal if we can. If we can't open the terminal, use stderr and stdin. */ - tty = fopen ("/dev/tty", "w+"); + tty = fopen ("/dev/tty", "w+e"); if (tty == NULL) { in = stdin; diff --git a/modules/getpass b/modules/getpass index 7e73451..74d781a 100644 --- a/modules/getpass +++ b/modules/getpass @@ -9,6 +9,7 @@ m4/getpass.m4 Depends-on: unistd extensions +fopen-gnu fseeko getline stdbool -- 2.7.4