>From bdf45d582b3761b281bd4eef8e5254f5a03e992a Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Wed, 27 May 2020 19:46:45 +0200 Subject: [PATCH 09/18] javacomp: Make more robust in multithreaded applications. * lib/javacomp.c (get_classfile_version): Pass an O_CLOEXEC flag to open(). * modules/javacomp (Depends-on): Add 'open'. --- ChangeLog | 7 +++++++ lib/javacomp.c | 2 +- modules/javacomp | 1 + 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index e793a13..8d139b4 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,12 @@ 2020-05-27 Bruno Haible + javacomp: Make more robust in multithreaded applications. + * lib/javacomp.c (get_classfile_version): Pass an O_CLOEXEC flag to + open(). + * modules/javacomp (Depends-on): Add 'open'. + +2020-05-27 Bruno Haible + getprogname: Make more robust in multithreaded applications. * lib/getprogname.c (getprogname): Pass an O_CLOEXEC flag to open(). * modules/getprogname (Depends-on): Add 'open'. diff --git a/lib/javacomp.c b/lib/javacomp.c index ac56196..4717a5f 100644 --- a/lib/javacomp.c +++ b/lib/javacomp.c @@ -597,7 +597,7 @@ get_classfile_version (const char *compiled_file_name) int fd; /* Open the class file. */ - fd = open (compiled_file_name, O_RDONLY | O_BINARY, 0); + fd = open (compiled_file_name, O_RDONLY | O_BINARY | O_CLOEXEC, 0); if (fd >= 0) { /* Read its first 8 bytes. */ diff --git a/modules/javacomp b/modules/javacomp index fccdaac..0552797 100644 --- a/modules/javacomp +++ b/modules/javacomp @@ -16,6 +16,7 @@ classpath xsetenv sh-quote binary-io +open safe-read xalloc xmalloca -- 2.7.4