Re: [PATCH] tests: pacify gcc -fanalyzer on zerosize_ptr

[Bernhard Voelker]

On 2020-07-02 01:48, Paul Eggert wrote:
> diff --git a/tests/test-memchr.c b/tests/test-memchr.c

> -  ASSERT (MEMCHR (zerosize_ptr (), 'a', 0) == NULL);
> +  void *page_boundary = zerosize_ptr ();
> +  if (page_boundary)
> +    ASSERT (MEMCHR (page_boundary, 'a', 0) == NULL);

This triggers a new shadowing warning (here with -Werror, gcc 10.1.1):

  test-memchr.c: In function 'main':
  test-memchr.c:98:11: error: declaration of 'page_boundary' shadows a previous 
local [-Werror=shadow]
     98 |     char *page_boundary = (char *) zerosize_ptr ();
        |           ^~~~~~~~~~~~~
  test-memchr.c:52:9: note: shadowed declaration is here
     52 |   void *page_boundary = zerosize_ptr ();
        |         ^~~~~~~~~~~~~
  cc1: all warnings being treated as errors

The attached fixes it.
Okay to push?

Have a nice day,
Berny

0001-tests-avoid-shadowing-warning.patch
Description: Text Data