Re: coreutils and GCC -fanalyzer

[Jeffrey Walton]

On Fri, Jul 10, 2020 at 5:22 PM Pádraig Brady <P@draigbrady.com> wrote:
>
> On 02/07/2020 01:26, Paul Eggert wrote:
> > On 5/23/20 9:08 AM, Paul Eggert wrote:
> >
> >> So I am thinking of killing two
> >> stones by doing the following.
> >>
> >> 1. Test for -fanalyzer, -Wall, -Wextra.
> >>
> >> 2. Test for flags not automatically enabled by -fanalyzer, -Wall, -Wextra 
> >> but
> >> flags that we want anyway.
> >>
> >> 3. Test for flags automatically enabled by -fanalyzer, -Wall, -Wextra that 
> >> are
> >> also flags that we don't want.
> >
> > I did that in Gnulib by installing the attached patch. This could greatly
> > increase compile times due to the -fanalyzer option, so let's keep an eye 
> > out
> > for that.
>
> s/could/does/.
> compile time has gone from seconds to minutes for coreutils at least.
>
> I'd be inclined to not enable -fanalyzer by default.
> At least not until it matures more.
> -fanalyzer didn't find any actual issues in coreutils,
> and currently bails on most files (after taking lots of time about it),
> as indicated with the -Wanalyzer-too-complex option.

Just my 2 cents, but leave analyzer options to testing and QA folks.
Make the option available for convenience, but leave it off by
default.

The testers and QA folks will perform the enhanced testing on
occasion, like during a CI build or manually before a release. The
remainder of the time, regular users get a regular build.

Jeff