Re: Missing '_Noreturn'

[Bruno Haible]

Gisle Vanem wrote:
> Thanks Paul for a fast patch. 10 minutes!
> 
> Here's an error though:
> 
>    test-dfa-match-aux.c
>    test-dfa-match-aux.c(39): error C2381: 'dfawarn': redefinition;
>    '__declspec(noreturn)' or '[[noreturn]]' differs
>    lib\dfa.h(125): note: see declaration of 'dfawarn'
> 
> which I fixed by:
> 
> --- a/lib/dfa.h 2020-01-04 13:18:15
> +++ b/lib/dfa.h 2020-07-26 21:52:26
> @@ -122,7 +122,7 @@
>      that likely doesn't do what the user wanted.  It takes a single
>      argument, a NUL-terminated string describing the situation.  The user
>      must supply a dfawarn.  */
> -extern void dfawarn (const char *);
> +extern _Noreturn void dfawarn (const char *);

The dfa.h file is correct; it's the test which needs a fix.

> Has something with 'dfa*' changed or it just the latest
> MSVC that got stricter on this?

Neither dfawarn nor the test has changed in 4 years.

Bruno