|
From: | Paul Eggert |
Subject: | Re: clang warnings in regcomp.c |
Date: | Sun, 6 Sep 2020 19:05:58 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 9/6/20 5:45 PM, Bruno Haible wrote:
What is the point of these parentheses?
Haven't a clue. It's an unusual style.
static reg_errcode_t preorder (bin_tree_t *root, - reg_errcode_t (fn (void *, bin_tree_t *)), + reg_errcode_t fn (void *, bin_tree_t *), void *extra);
For corrections like that I suggest the style "reg_errcode_t (*fn) (void *, bin_tree_t *)" instead, as that's the usual style in glibc and I expect it is the style that was intended in regcomp.c anyway.
[Prev in Thread] | Current Thread | [Next in Thread] |