bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: parse-datetime: Fix compilation error with bison 3.7


From: Daiki Ueno
Subject: Re: parse-datetime: Fix compilation error with bison 3.7
Date: Sun, 13 Sep 2020 08:24:45 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Bruno Haible <bruno@clisp.org> writes:

>> 2020-07-28  Bruno Haible  <bruno@clisp.org>
>> 
>>      parse-datetime: Fix compilation error with bison 3.7.
>>      * modules/parse-datetime (Makefile.am): Create a generated header file
>>      parse-datetime-gen.h in the source directory. Correct #include and
>>      #line statements during preprocessing.

Thank you for those fixes; they are going to fix long standing build
failures in GnuTLS.  One thing I noticed though is that
parse-datetime-gen.h has no dependency declaration and fails to build
with parallel make:

  make[2]: *** No rule to make target 'parse-datetime-gen.h', needed by 'all'.  
Stop.
  make[2]: *** Waiting for unfinished jobs....
    YACC     parse-datetime.c
  make[2]: Leaving directory '/tmp/gnutls/build/src/gl'
  make[1]: *** [Makefile:1761: all-recursive] Error 1

The attached patch fixes it; OK to push?

Regards,
-- 
Daiki Ueno
>From 1ba354a39b0ae34852a4ab9b25137fe65e59cd0f Mon Sep 17 00:00:00 2001
From: Daiki Ueno <ueno@gnu.org>
Date: Sun, 13 Sep 2020 08:17:13 +0200
Subject: [PATCH] parse-datetime: fix compilation error with parallel make

* modules/parse-datetime (Makefile.am): Mark explicit dependency
from parse-datetime-gen.h to parse-datetime.c generation.
---
 ChangeLog              | 6 ++++++
 modules/parse-datetime | 1 +
 2 files changed, 7 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index 66aec61cb..2ef8d7585 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2020-09-13  Daiki Ueno  <ueno@gnu.org>
+
+       parse-datetime: fix compilation error with parallel make
+       * modules/parse-datetime (Makefile.am): Mark explicit dependency
+       from parse-datetime-gen.h to parse-datetime.c generation.
+
 2020-09-12  Paul Eggert  <eggert@cs.ucla.edu>
 
        dfa: epsilon-closure tweaks (Bug#40634)
diff --git a/modules/parse-datetime b/modules/parse-datetime
index 14675194e..ced61abf4 100644
--- a/modules/parse-datetime
+++ b/modules/parse-datetime
@@ -43,6 +43,7 @@ Makefile.am:
 # Additionally, here we assume GNU Bison and therefore don't need the ylwrap
 # script.
 # Therefore we override this rule.
+parse-datetime-gen.h: parse-datetime.c
 parse-datetime.c: parse-datetime.y
        $(AM_V_YACC)$(PARSE_DATETIME_BISON) -d $(YFLAGS) $(AM_YFLAGS) 
$(srcdir)/parse-datetime.y \
        && test ':' = '$(PARSE_DATETIME_BISON)' || { \
-- 
2.26.2


reply via email to

[Prev in Thread] Current Thread [Next in Thread]